Fix get-demos CI: remove module.exports incompatible with Node 24 - #386
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job get-demos
Fix get-demos CI: remove module.exports incompatible with Node 24
Jul 3, 2026
SeiferTim
marked this pull request as ready for review
July 3, 2026 21:03
There was a problem hiding this comment.
Pull request overview
This PR fixes the get-demos GitHub Actions job on newer runners (Node 24 default) by updating the inline actions/github-script usage to avoid module.exports, which is not available in the inline eval() execution context.
Changes:
- Removed the
module.exports = ({core}) => { ... }wrapper from the inlinegithub-scriptblock. - Kept the existing folder scan logic and
try/catchfailure handling while returning the demo path list for downstream matrix expansion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SeiferTim
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get-demosjob fails withReferenceError: module is not definedbecause GitHub Actions runners now default to Node 24, wheremoduleis not available in theeval()context used byactions/github-scriptfor inline scripts.Changes
.github/workflows/build-concurrently.yml: Removed themodule.exports = ({core}) => { ... }wrapper from the inlinegithub-scriptscript. Inline scripts run as the body of an async function withcorealready in scope —module.exportsis only valid for external script files, not inline usage.